EricWF updated this revision to Diff 37376.
EricWF added a comment.
Updating diff so it merges cleanly against master.
http://reviews.llvm.org/D12508
Files:
CMakeLists.txt
lib/CMakeLists.txt
test/CMakeLists.txt
utils/gen_link_script/gen_link_script.py
Index: utils/gen_link_script/gen_l
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm accepting this revision because the feedback about this patch has been
positive. I will submit another patch that makes this behavior default as
suggested
rsmith added a comment.
I think this is a good direction. I used to link libc++abi into libc++, and
switched to using a hand-rolled linker script a while back. It's been working
great for me.
http://reviews.llvm.org/D12508
___
cfe-commits mailing
EricWF added a comment.
@mclow.lists ping. Do you think this is the right approach to fix linking the
ABI library?
@rsmith: I think you asked for this functionality a while ago. Any thoughts?
http://reviews.llvm.org/D12508
___
cfe-commits mailing l
jroelofs added a comment.
I trust your judgement.
http://reviews.llvm.org/D12508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added inline comments.
Comment at: utils/gen_link_script/gen_link_script.py:1
@@ +1,2 @@
+#!/usr/bin/env python
+import os
jroelofs wrote:
> Do you foresee these linker scripts being significantly more complicated for
> other platforms? ISTM that it would
jroelofs added inline comments.
Comment at: utils/gen_link_script/gen_link_script.py:1
@@ +1,2 @@
+#!/usr/bin/env python
+import os
Do you foresee these linker scripts being significantly more complicated for
other platforms? ISTM that it would be much simpler to
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs, rsmith.
EricWF added a subscriber: cfe-commits.
Currently on most platforms you have to manually link the c++ abi library used
with libc++ whenever you use libc++. So your typical libc++ command like
invocati
