[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui added a comment. Thank you all so much :))) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125078/new/ https://reviews.llvm.org/D125078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

xbolva00 added a comment. In D125078#3503921 , @cjdb wrote: > I support turning it on by default. I'm simply passing on the message. +1, I support on by default as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui added a comment. Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125078/new/ https://reviews.llvm.org/D125078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

cjdb added a comment. I support turning it on by default. I'm simply passing on the message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125078/new/ https://reviews.llvm.org/D125078 ___ cfe-commits mai

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui added a comment. This feature is already implemented in GCC, so in my opinion, it would be great if we could turn this on by default. I also added a feature to separate location info and a message in https://reviews.llvm.org/D125175. Should its feature be avoided from turning on by d

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

xbolva00 added a comment. In D125078#3501061 , @cjdb wrote: > I'm in favour of this, but @rsmith warned me a little while ago that we > mightn't be able to have stuff like this on by default because scripts > probably depend on specific compiler output.

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

cjdb added subscribers: rsmith, cjdb. cjdb added a comment. I'm in favour of this, but @rsmith warned me a little while ago that we mightn't be able to have stuff like this on by default because scripts probably depend on specific compiler output. Hyrum's Law strike

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui updated this revision to Diff 427546. ken-matsui added a comment. Remove unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125078/new/ https://reviews.llvm.org/D125078 Files: clang/include/clang/Basic/DiagnosticOption

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui created this revision. Herald added a project: All. ken-matsui requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. I implemented a feature to show line numbers with left margins in diagnostics like GCC-9 does. Ref: https://