[PATCH] D125061: [clang] A more robust way to attach comments

2022-05-05 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi added a comment. Since the issue is specific to enumerators I would recommend against increasing the size of `DeclBase`, which would increase the size of every single `Decl` in the AST. There are multiple ways to approach this: - Consider whether bringing back the comma check just for

[PATCH] D125061: [clang] A more robust way to attach comments

2022-05-05 Thread Zixu Wang via Phabricator via cfe-commits
zixuw added a comment. Well, apparently there are still some corner-case bugs in the logic. ExtractAPI and a few other tests failed. Will look into it tomorrow. And if folks have concerns or opinions of the performance/space cost of adding the extra pointer to `DeclBase`, I can try to keep the

[PATCH] D125061: [clang] A more robust way to attach comments

2022-05-05 Thread Zixu Wang via Phabricator via cfe-commits
zixuw created this revision. Herald added a subscriber: arphaman. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current implementation in `getRawCommentForDeclNoCacheIm