[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG75bb815231f6: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang (authored by MattDevereau). Changed prior to commit: https://reviews.llvm.org/D124998?vs=427335&id=428644#toc Repository: rG LLVM G

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D124998#3503335 , @paulwalker-arm wrote: > @aaron.ballman It looks like the conversation reached a conclusion? Given > this is sepa

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. @aaron.ballman It looks like the conversation reached a conclusion? Given this is separate to what we're trying to add here can this patch be unblocked? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/ htt

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3494814 , @erichkeane wrote: > First: I care very little about `FunctionNoProtoType`. I care insomuch as it doesn't break valid user code. > Second, it is used only in "C" afaik, where our memory pressure isn't

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. I don't want to change with the distinction between FunctionProtoType and FunctionNoProtoType; that would involve auditing a bunch of code we don't really want to mess with. FunctionProtoType and FunctionNoProtoType don't have any member variables at the moment, thoug

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494785 , @aaron.ballman wrote: > In D124998#3494500 , @erichkeane > wrote: > >> In D124998#3494442 , @efriedma >> wrote: >> >>>

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3494500 , @erichkeane wrote: > In D124998#3494442 , @efriedma > wrote: > >> In D124998#3494426 , @erichkeane >> wrote: >> >>>

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494442 , @efriedma wrote: > In D124998#3494426 , @erichkeane > wrote: > >> In D124998#3494424 , @efriedma >> wrote: >> >>> If you

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

tschuett added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, tschuett wrote: > aaron.ballman wrote: > > peterwaller-arm wrote: > > > peterwaller-arm wrote: > > > > It should

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. In D124998#3494426 , @erichkeane wrote: > In D124998#3494424 , @efriedma > wrote: > >> If you're really concerned about the size of FunctionProtoType increasing, >> can we just shove t

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494424 , @efriedma wrote: > If you're really concerned about the size of FunctionProtoType increasing, > can we just shove the infrequently used calling convention bits into > TrailingObjects? I don't believe so.

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. If you're really concerned about the size of FunctionProtoType increasing, can we just shove the infrequently used calling convention bits into TrailingObjects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/ h

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494388 , @paulwalker-arm wrote: > In D124998#3494127 , @aaron.ballman > wrote: > >> In D124998#3493791 , >> @paulwalker-arm wrot

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. In D124998#3494127 , @aaron.ballman wrote: > In D124998#3493791 , > @paulwalker-arm wrote: > >> Just wanted to say this is not a new calling convention as such, but rather >> an

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3493791 , @paulwalker-arm wrote: > Just wanted to say this is not a new calling convention as such, but rather > an existing one that is generally auto-detected based on function signature. > The problem we're

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

MattDevereau updated this revision to Diff 427335. MattDevereau added a comment. set `CXCallingConv_AArch64SVEPcs= 17` to 18 to resolve ABI break renamed CC_AArch64SVEPcs to CC_AArch64SVEPCS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. Just wanted to say this is not a new calling convention as such, but rather an existing one that is generally auto-detected based on function signature. The problem we're trying to solve here is that we need a way to allow a user to force the calling convention

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Specifiers.h:283 CC_AArch64VectorCall, // __attribute__((aarch64_vector_pcs)) +CC_AArch64SVEPcs, // __attribute__((aarch64_sve_pcs)) }; aaron.ballman wrote: > I continue to be con

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

tschuett added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, aaron.ballman wrote: > peterwaller-arm wrote: > > peterwaller-arm wrote: > > > It shouldn't matter in principle

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Making it clear there are necessary changes (at least to unbreak the C ABI). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, peterwaller-arm wrote: > peterwaller-arm wrote: > > It shouldn't matter in principle (... "but in practice"

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

peterwaller-arm added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, peterwaller-arm wrote: > It shouldn't matter in principle (... "but in practice" ...) we should > probab

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. Looks good to me with minor nits. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, ---

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

MattDevereau created this revision. MattDevereau added reviewers: paulwalker-arm, peterwaller-arm, bsmith, DavidTruby, dtemirbulatov. Herald added subscribers: ctetreau, psnobl, arphaman, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a reviewer: aaron.ballman. Herald add