This revision was automatically updated to reflect the committed changes.
Closed by commit rG8b626a2caa67: [clang-format] Fix another bug in
AlignConsecutiveAssignments (authored by owenpan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124956/new/
owenpan added a comment.
No, because the first part of that test case would cause non-consecutive
assignments to be aligned. (See
https://github.com/llvm/llvm-project/issues/55265.) Only then would the `if`
block be treated as a braced list and get misindented. We should definitely use
test ca
curdeius added a comment.
Just one last thought, shouldn't we have a test case close to what was reported
in the issue? I.e. with PP directives.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124956/new/
https://reviews.llvm.org/D124956
__
curdeius accepted this revision.
curdeius added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124956/new/
https://reviews.llvm.org/D124956
___
cfe-commits mailing list
cfe-commits@lists.
owenpan created this revision.
owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay.
owenpan added a project: clang-format.
Herald added a project: All.
owenpan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Similar to D12
