This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG58abe36ae765: [clang][dataflow] Add flowConditionIsTautology
function (authored by li.zhe.hua).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
li.zhe.hua marked 4 inline comments as done.
li.zhe.hua added a comment.
Ah, good catch regarding the flow condition deps not being tracked. Thanks for
the review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124943/new/
https://reviews.llvm.org/
li.zhe.hua updated this revision to Diff 427183.
li.zhe.hua added a comment.
Address reviewer comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124943/new/
https://reviews.llvm.org/D124943
Files:
clang/include/clang/Analysis/FlowSensitive/
li.zhe.hua added a comment.
I'm playing around with a tool to take raw pointers and add a non-null
annotation or convert them to references, for code that is assumed to be
correct. So in this case, "interesting expression" is anything that would be UB
if the pointer was null, e.g. dereferencing
sgatev accepted this revision.
sgatev added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:176-177
+ /// Returns true if the constraints of the flow condition identified by
+ /// `Token` is always true.
+ bool flowCondition
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
The code looks good to me too. I was also wondering what sort of check will
need this info.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
li.zhe.hua added a comment.
This allows me to query when an expression is always encountered/executed.
Alternatively, if I have a set of interesting expressions, I can note the flow
condition at every expression, compute the disjunction of the set of flow
conditions, and determine if execution
ymandel added a comment.
The code looks good, but what is the intended application?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124943/new/
https://reviews.llvm.org/D124943
___
cfe-commits mailing list
li.zhe.hua created this revision.
li.zhe.hua added reviewers: ymandel, sgatev, xazax.hun.
Herald added subscribers: tschuett, steakhal, rnkovacs.
Herald added a project: All.
li.zhe.hua requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Provid
