[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-23 Thread Anastasia Stulova via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72832efc941a: [SPIR-V] Allow setting SPIR-V version via target triple. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-19 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-16 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 429678. Anastasia added a comment. Fixed typo in docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 Files: llvm/docs/SPIRVUsage.rst llvm/docs/UserGuides.rst llvm/include/llvm/ADT/Triple.h llvm/

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-09 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: llvm/docs/SPIRVUsage.rst:14 + +The SPIR-V target provides code generation for the SPIR-V binary format desribed +in `the official SPIR-V specification `_. described CHANGES

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-09 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 428118. Anastasia added a comment. - Added v1.5. - Changed wording in documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 Files: llvm/docs/SPIRVUsage.rst llvm/docs/UserGuides.rst llvm/in

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-09 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D124776#3497689 , @iliya-diyachkov wrote: > @Anastasia, when are you going to add support for v1.5? We would use it in > the SPIR-V backend. Ok, I can add it straight away if there is a use-case. So far I have taken the l

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-09 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki added inline comments. Comment at: llvm/docs/SPIRVUsage.rst:55 + == + ** Generic SPIR-V target without any vendor-specific settings. + ===

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

2022-05-06 Thread Ilia Diachkov via Phabricator via cfe-commits
iliya-diyachkov added a comment. @Anastasia, when are you going to add support for v1.5? We would use it in the SPIR-V backend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailin