[PATCH] D124753: [HLSL] Set main as default entry.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140b0bf89902: [HLSL] Set main as default entry. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 453747. python3kgae added a comment. Update to work around arc error when land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Drive

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 450492. python3kgae marked an inline comment as done. python3kgae added a comment. Rebase and add unit-test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:14 +// CHECK-NOT: "dx.shader"="compute" +// CHECK-SAM: } +[numthreads(1, 1, 1)] void main() { bogner wrote: > typo, should be `C

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 436898. python3kgae added a comment. Fix typo in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td clang/test

[PATCH] D124753: [HLSL] Set main as default entry.

bogner added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:14 +// CHECK-NOT: "dx.shader"="compute" +// CHECK-SAM: } +[numthreads(1, 1, 1)] void main() { typo, should be `CHECK-SAME` Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added a comment. In D124753#3550670 , @python3kgae wrote: > In D124753#3550337 , @Anastasia > wrote: > >> In D124753#3546608 , @python3kgae >> wrote: >> >>> I

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae added a comment. In D124753#3550337 , @Anastasia wrote: > In D124753#3546608 , @python3kgae > wrote: > >> In D124753#3545779 , @Anastasia >> wrote: >> >>> Fr

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added a comment. In D124753#3546608 , @python3kgae wrote: > In D124753#3545779 , @Anastasia > wrote: > >> From the current change it seems to me that what you need to be testing is a >> just that the

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 433301. python3kgae added a comment. Cleanup test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td clang/test/Cod

[PATCH] D124753: [HLSL] Set main as default entry.

MaskRay added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:6 +// Make sure not mangle entry. +// CHECK:define void @main() [[MAIN_ATTR:#[0-9]]] +// CHECK:define void @_Z3foov() [[FOO_ATTR:#[0-9]]] space between `:` and the value. =

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 433006. python3kgae added a comment. Add new line at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae added a comment. In D124753#3545779 , @Anastasia wrote: > From the current change it seems to me that what you need to be testing is a > just that the frontend options are being passed correctly? This should then > be a driver test with `-##

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added a comment. From the current change it seems to me that what you need to be testing is a just that the frontend options are being passed correctly? This should then be a driver test with `-###` checking for the options to be set for the frontend invocation... Repository: rG L

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432606. python3kgae marked 2 inline comments as done. python3kgae added a comment. Use default value of MarshallingInfoString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.

[PATCH] D124753: [HLSL] Set main as default entry.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:194 +const StringRef DefaultEntry = "main"; +DAL->AddSeparateArg(nullptr, Opts.getOption(options::OPT_hlsl_entrypoint), +DefaultEntry); Instead of lett

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432429. python3kgae added a comment. Add test for main is not entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/lib/Driver/ToolChains/HLSL.cpp

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tcs_6_1 -fcgl -Fo - %s | FileCheck %s + Would it make sense to test the opposite i.e. if `-E` is passed in the command line `main` is not

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432023. python3kgae added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/lib/Driver/ToolChains/HLSL.cpp clang/test/C

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:182 } + // If not set entry, default is main. + if (!DAL->hasArg(options::OPT_hlsl_entrypoint)) { -> `If no set entry` or `If entry is not set explicitly` Repository: rG LL

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a proje