[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD added a comment. Could you please commit this for me, @rjmccall? I'm wondering if there's a chance this could be backported to the LLVM 14 branch. We've been running into the linked issue in production, it would be great if it were fixed in the next point release. Repository: rG

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124736/new/ https://reviews.llvm.org/D124736 ___

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD updated this revision to Diff 428225. BertalanD added a comment. Use ABI alignment for allocating operator new as well. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124736/new/ https://reviews.llvm.org/D124736 File

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD added a comment. In D124736#3485128 , @rjmccall wrote: > It should probably be the ABI alignment in all cases; I think the preferred > alignment is just supposed to be used to opportunistically over-align things > like e.g. local variables, wh

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

rjmccall added a comment. It should probably be the ABI alignment in all cases; I think the preferred alignment is just supposed to be used to opportunistically over-align things like e.g. local variables, which doesn't seem relevant for the ABI code involving a call to `operator new`. Reposi

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD updated this revision to Diff 426303. BertalanD added a comment. Removed accidental execute permission from the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124736/new/ https://reviews.llvm.org/D124736 Files: clang/lib/CodeGen/C

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD updated this revision to Diff 426301. BertalanD added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124736/new/ https://reviews.llvm.org/D124736 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenC

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD created this revision. Herald added a project: All. BertalanD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we do not know the alignment of the operand, we can't assume it has the preferred alignment. It might be e.g. a point