[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng added a comment. @kadircet Proposed fix: D138429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730 ___ cfe-commits m

Re: [PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

thanks Kito! not sure if you've noticed D138287, but if landing a solution is going to take a long while here, i'd like to move forward with that approach to make sure this doesn't stay in a broken state. so it'd be great if you can give some updates/estimates about fixing this soon. On Mon, Nov 2

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng marked 2 inline comments as done. kito-cheng added a comment. @kadircet ooops, sorry for missing your comment, let me figure out how to fix that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kadircet added a comment. In D124730#3916786 , @kadircet wrote: > Hi @kito-cheng, can you please let us know if you're working on a fix here > (and whether it seems to be close)? otherwise i am planning to revert this > and consequent changes, as it's c

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kadircet added a comment. Hi @kito-cheng, can you please let us know if you're working on a fix here (and whether it seems to be close)? otherwise i am planning to revert this and consequent changes, as it's clearly introducing data races. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kadircet added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:35 +// Concat BasicType, LMUL and Proto as key +static std::unordered_map LegalTypes; +static std::set IllegalTypes; these were previously owned by `RVVEmitter`, hence we would

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff0bf576b84: [RISCV][NFC] Refactor RISC-V vector intrinsic utils. (authored by kito-cheng). Changed prior to commit: https://reviews.llvm.org/D124730?vs=429184&id=429620#toc Repository: rG LLVM Gith

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. Thanks Kito. This all LGTM except some warnings need to fix. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:384 +return PD; // Handle primitive type transforme

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:55 +// basic vector type, used to compute type info of arguments. +enum class PrimitiveType : uint8_t { + Invalid, khchen wrote: > I think vector is not a primitive

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng updated this revision to Diff 429184. kito-cheng marked 3 inline comments as done. kito-cheng added a comment. Changes: - Address @khchen's comment. - Use new hash scheme for cache the result of computeType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

khchen added a comment. Herald added a subscriber: shiva0217. Thanks for refactoring! Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:55 +// basic vector type, used to compute type info of arguments. +enum class PrimitiveType : uint8_t { + Invalid, -

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng updated this revision to Diff 426276. kito-cheng added a comment. Changes: - Extract more utils functions to RISCVVIntrinsicUtils Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730 Files: clang

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, si