tahonermann closed this revision.
tahonermann added a comment.
Re-closing since this review has already landed.
@akyrtzi, did you see my last comment? If I don't hear back from you, I'll
submit a new doc change that covers both forms of PCH use.
Repository:
rG LLVM Github Monorepo
CHANGES S
tahonermann reopened this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.
Reopening for further discussion or clarification.
The changes appear to suggest that a PCH file won't be implicitly used when an
explicit include for the corresponding header is mad
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6112f490cfe: [docs] PCH usage documentation update
(authored by ivanmurashko).
Changed prior to commit:
https://reviews.llvm.org/D124719?vs=42658
ivanmurashko updated this revision to Diff 426588.
ivanmurashko added a comment.
Some clarifications for the direct include example were added
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124719/new/
https://reviews.llvm.org/D124719
Files:
clan
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for improving the docs!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124719/new/
https://reviews.llvm.org/D124719
_
