This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb9f3b7f89a4c: [flang][driver] Add support for consuming LLVM
IR/BC files (authored by awarzynski).
Changed prior to commit:
https://reviews.llvm.o
awarzynski updated this revision to Diff 427032.
awarzynski added a comment.
Rebase on top of main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124667/new/
https://reviews.llvm.org/D124667
Files:
clang/include/clang/Driver/Types.h
clang/lib/D
awarzynski updated this revision to Diff 426678.
awarzynski marked 2 inline comments as done.
awarzynski added a comment.
Add an assert, make some editorial changes in comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124667/new/
https://revie
awarzynski marked 8 inline comments as done.
awarzynski added a comment.
Thanks for the review @rovka!
Comment at: flang/lib/Frontend/FrontendActions.cpp:86
+
+ // ... otherwise, generate an MLIR module from the input Fortran source
bool res = RunPrescan() && RunParse() &&
rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.
A few nits, but otherwise LGTM.
Comment at: flang/lib/Frontend/FrontendActions.cpp:86
+
+ // ... otherwise, generate an MLIR module from the input Fortran source
bool res =
awarzynski created this revision.
awarzynski added reviewers: rovka, kiranchandramohan, Leporacanthicus,
unterumarmung, ekieri.
Herald added a subscriber: mgorny.
Herald added a reviewer: sscalpone.
Herald added projects: Flang, All.
awarzynski requested review of this revision.
Herald added subsc