[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert updated this revision to Diff 425670. aaronpuchert edited the summary of this revision. aaronpuchert removed a subscriber: drodriguez. aaronpuchert added a comment. Herald added a subscriber: jdoerfert. Drop `* text=auto`, so that we renormalize only the files that need it. Reposito

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. In D124563#3478653 , @modimo wrote: > I think the way to go is to revert ac5f7be6a868 > then > land everything as a single stack to prevent this issue.

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478627 , @smeenai wrote: > If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and > `clang-tools-extra/test/clang-apply-repl

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. In D124563#3478747 , @aaronpuchert wrote: > How about we remove `* text=auto` for now? Or would that break something? The documentation says that: > If you want to ensure that t

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. In D124563#3478625 , @smeenai wrote: > I *think* this would mean that if you're on Windows and have `core.autocrlf` > set to `input`, when you commit changes to this files, Git will convert them > back to LF line endings. N

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478625 , @smeenai wrote: > I *think* this would mean that if you're on Windows and have `core.autocrlf` > set to `input`, when you commit changes to this files, Git will convert them > back to LF line endings. Not

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. Regarding `crlf.cpp`(`.expected`), adding the modified changes to a commit indeed solved the problem I described in https://reviews.llvm.org/rGac5f7be6a8688955a282becf00eebc542238a86b#1080897 and I was working with that so far. Still don't know why Linux git doesn't

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

modimo added a comment. In D124563#3478627 , @smeenai wrote: > If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and > `clang-tools-extra/test/clang-apply-replacem

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

modimo added a comment. In D124563#3478561 , @smeenai wrote: > The following files have their line endings (when checked out on disk) > changed from CRLF to LF by this patch. Seems harmless, but I just wanted to > confirm that it was expected: > > >

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. If I check out this commit and then check out the previous commit, `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp.expected` become modified in my working directory; their l

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. In D124563#3478623 , @aaronpuchert wrote: > So maybe we should simply remove > > # These test input files rely on two-byte Windows (CRLF) line endings. > clang-apply-replacements/Inputs/crlf/crlf.cpp text eol=crlf > clang-a

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. Most of the files changed here are not affected by the `.gitattributes` file, such as clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readability-duplicate-include.h clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. The following files have their line endings (when checked out on disk) changed from CRLF to LF by this patch. Seems harmless, but I just wanted to confirm that it was expected: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readabilit

[PATCH] D124563: renormalize

modimo created this revision. Herald added subscribers: hoy, wenlei. Herald added a project: All. modimo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124563 Fi