[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

2022-04-27 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui added a comment. Hi @aaron.ballman, Thank you for your review! I updated the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 ___ cfe-commits m

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

2022-04-27 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui updated this revision to Diff 425601. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

2022-04-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this new diagnostic! Comment at: clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1 - -// This file intentionally uses a CRLF newlines! - -void foo() { -

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

2022-04-27 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui added a comment. This change is related to: https://github.com/llvm/llvm-project/issues/55067 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 ___ cfe

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

2022-04-27 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui created this revision. Herald added a project: All. ken-matsui requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124534 Files: clang-tools-extra/