[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Integrated slowly and surely as part of the stack leading up to D127911 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim planned changes to this revision. hctim added a comment. Pulled out the IR-specific changes to D126100 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 __

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

eugenis added a comment. I've always viewed the current implementation as a hack, and believed this data should live in debug info. It can be convenient to get symbolized reports for global overflow bug in a stripped binary, but those bugs are quite rare, and "symbolization" only affects the g

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:33 + +class SanitizerMetadataFactory { + SanitizerMetadataFactory(const SanitizerMetadataFactory &) = delete; Not sure if this class follows the 'factory' design pattern,

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:6 +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===--===// vitalybuka wrote: > can

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

vitalybuka added a comment. In D124493#3477432 , @filcab wrote: > Hi @hctim, thanks for the patch. > I have one question, though. Do you really need to remove the information you > removed? > Some people might be testing ASan binaries without access to d

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added a comment. One meta-observation: can you split this into smaller patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 ___ cfe-commits maili