[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

smeenai resigned from this revision. smeenai added a comment. LGTM after changing to an error with a warning downgrade. Resigning to clear my queue, plus the Apple folks should get the final accept here :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

delcypher added a comment. I spoke to a few other engineers in Apple. They are 1. Happy for us to proceed with marking `LLVM_BUILD_EXTERNAL_COMPILER_RT` as deprecated. 2. Okay with using `LLVM_BUILD_EXTERNAL_COMPILER_RT` being an error by default that can be downgraded to a warning using a CMak

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

phosek added a comment. I'd be in favor of defaulting to an `ERROR` and providing an option to downgrade to a `WARNING`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 __

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

delcypher added a comment. > Making it an ERROR and providing an option to downgrade it to a WARNING seems > reasonable to me. Thoughts? One nice property this would have is it would (eventually) allow us to collect a list of all the places that depend on this old code. It is potentially quite

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

beanz added a comment. Making it an `ERROR` and providing an option to downgrade it to a `WARNING` seems reasonable to me. Thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 __

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

smeenai added a comment. I don't think many people are gonna notice a warning in the general spew of CMake configuration, tbh. Would it be too disruptive to make this an error instead and have a CMake option you can pass to get rid of the error? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

beanz updated this revision to Diff 425353. beanz added a comment. Making the warning message more specific. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 Files: clang/runtime/CMakeLists.txt Index:

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

beanz created this revision. beanz added reviewers: delcypher, phosek, compnerd, ldionne, smeenai. Herald added a subscriber: mgorny. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. This patch goes with the RFC posted here: https://discourse.llv