[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a47accda88c: [Analyzer] Fix clang::ento::taint::dumpTaint definition (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ ht

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D124462#3482728 , @mantognini wrote: > In D124462#3480348 , @aaron.ballman > wrote: > >> In D124462#

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3480348 , @aaron.ballman wrote: > In D124462#3480219 , @steakhal > wrote: > >> Thanks for the stats. >> @aaron.ballman WDYT, where should we put the `LLVM_DUMP_METHOD` ? >

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

aaron.ballman added a comment. In D124462#3480219 , @steakhal wrote: > Thanks for the stats. > @aaron.ballman WDYT, where should we put the `LLVM_DUMP_METHOD` ? The documentation for the attribute says function definitions, but I don't think it matters

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal added a subscriber: aaron.ballman. steakhal added a comment. Thanks for the stats. @aaron.ballman WDYT, where should we put the `LLVM_DUMP_METHOD` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ https://reviews.llvm.org/D124462

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini updated this revision to Diff 425772. mantognini added a comment. Remove LLVM_DUMP_METHOD from definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ https://reviews.llvm.org/D124462 Files: clang/lib/StaticAnalyzer/Check

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3477115 , @steakhal wrote: > Although gcc (and probably clang too) allows specifying > `__attribute__((noinline))` at any declaration (by merging //compatible// > attributes), I would prefer not to repeat ourselves

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal added a comment. Although gcc (and probably clang too) allows specifying `__attribute__((noinline))` at any declaration (by merging //compatible// attributes), I would prefer not to repeat ourselves. The attribute must be present at the header to force all usages not to inline it, henc

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3476581 , @steakhal wrote: > Could you please elaborate whats the motivation for this change? Right, I could have been more explicit. Sorry about that. `dumpTaint` is declared inside the `taint` namespace in the he

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal added a reviewer: steakhal. steakhal added a comment. Could you please elaborate whats the motivation for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ https://reviews.llvm.org/D124462

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini published this revision for review. mantognini added revie