This revision was automatically updated to reflect the committed changes.
owenpan marked an inline comment as done.
Closed by commit rGdb57acff2647: [clang-format] Adjust editor cursor position
past #include blocks (authored by owenpan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
owenpan marked an inline comment as done.
owenpan added inline comments.
Comment at: clang/unittests/Format/SortIncludesTest.cpp:895
+ Style.IncludeBlocks = Style.IBS_Regroup;
+ std::string Code = "#include \"b\"\n" // Start of line: 0
+ "\n"
owenpan updated this revision to Diff 425376.
owenpan added a comment.
Updated the test case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124452/new/
https://reviews.llvm.org/D124452
Files:
clang/lib/Format/Format.cpp
clang/unittests/Format/SortIncludesTest.cpp
Index: clang/uni
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added inline comments.
Comment at: clang/unittests/Format/SortIncludesTest.cpp:895
+ Style.IncludeBlocks = Style.IBS_Regroup;
+ std::string Code = "#include \"b\"\n" // Start of line: 0
+ "\n"
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
Looks ok, but I'm not very familiar with this part of clang-format, so please
leave some time for others to chime in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
owenpan created this revision.
owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay.
owenpan added a project: clang-format.
Herald added a project: All.
owenpan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://
