[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire abandoned this revision. junaire added a comment. Herald added a subscriber: bzcheeseman. Prefer https://reviews.llvm.org/D131464 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124434/new/ https://reviews.llvm.org/D124434 __

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3480915 , @dblaikie wrote: > I guess coming back to your other point about restructing the way all this > testing works (be a pity to gate the default change on this work as it sounds > like a big project) - yea

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

dblaikie added a comment. In D124434#3480519 , @aaron.ballman wrote: > In D124434#3480481 , @dblaikie > wrote: > >> Yeah, I have mixed feelings - I think at least in theory, C++ tries to be >> mostly backwards

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3480481 , @dblaikie wrote: > Yeah, I have mixed feelings - I think at least in theory, C++ tries to be > mostly backwards compatible and so old tests should run successfully in new > language modes - and I guess

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

dblaikie added a comment. In D124434#3479828 , @aaron.ballman wrote: > In D124434#3479051 , @junaire wrote: > >>> In general, my concern with the this patch is that it loses test coverage >>> by specifying an ex

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3479051 , @junaire wrote: >> In general, my concern with the this patch is that it loses test coverage by >> specifying an explicit language mode. We typically prefer to fix the tests >> so that they can work in

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire planned changes to this revision. junaire added a comment. > In general, my concern with the this patch is that it loses test coverage by > specifying an explicit language mode. We typically prefer to fix the tests so > that they can work in any language mode (and perhaps add additional

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

aaron.ballman added a comment. In D124434#3475006 , @dblaikie wrote: > @rsmith @aaron.ballman - might be especially interesting to know your > thoughts on the C++ chapter-based testing and what the intent there is as > clang changes default versions/new

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

dblaikie added subscribers: aaron.ballman, rsmith. dblaikie added a comment. @rsmith @aaron.ballman - might be especially interesting to know your thoughts on the C++ chapter-based testing and what the intent there is as clang changes default versions/new versions are added. (& also whether ther

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire created this revision. junaire added reviewers: dblaikie, nikic, tstellar. Herald added a subscriber: mstorsjo. Herald added a project: All. junaire requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project