[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

This revision was automatically updated to reflect the committed changes. Closed by commit rG955a05a2782e: [clang][dataflow] Optimize flow condition representation (authored by sgatev). Changed prior to commit: https://reviews.llvm.org/D124395?vs=425221&id=426298#toc Repository: rG LLVM Gith

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev marked an inline comment as done. sgatev added a comment. In D124395#3474597 , @ymandel wrote: > Nice work. On the surface, this adds complexity to the system and so should > be justified in terms of performance improvements. However, having read

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev updated this revision to Diff 425221. sgatev marked 4 inline comments as done. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124395/new/ https://reviews.llvm.org/D124395 Files: clang/include/clang

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice work. On the surface, this adds complexity to the system and so should be justified in terms of performance improvements. However, having read through the patch, I think it overall redu

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev marked an inline comment as done. sgatev added a comment. In D124395#3472974 , @xazax.hun wrote: > Nice! Did you do some measurements? Does this improve the performance or > decrease the memory consumption? I didn't do any measurements :( I imple

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev updated this revision to Diff 425143. sgatev marked 2 inline comments as done. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124395/new/ https://reviews.llvm.org/D124395 Files: clang/include/clang

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

xazax.hun added a comment. Nice! Did you do some measurements? Does this improve the performance or decrease the memory consumption? Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:160 + void addFlowConditionConstraint(AtomicBoolValue &Token,

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev updated this revision to Diff 424930. sgatev added a comment. Mark methods as const. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124395/new/ https://reviews.llvm.org/D124395 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnal

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Represent flow conditions as Token <=> Constraints bic