[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman closed this revision. aaron.ballman added a comment. I've landed in 2cb2cd242ca08d0bbd2a51a41f1317442e5414fc and will keep my eyes on the bots for long tail issues from the diagnostic change. CHANGES SINCE LAST

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added a comment. Assuming no further comments from reviewers, I plan to land this sometime tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.llvm.org/D124258 ___ cfe-commits mailing list cfe-co

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. @rsmith -- do you have any lingering concerns about the severity of the diagnostic? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.llvm.org/D124258 ___

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added inline comments. Comment at: clang/unittests/AST/SourceLocationTest.cpp:135-145 TEST(ParmVarDecl, KNRLocation) { LocationVerifier Verifier; - Verifier.expectLocation(1, 8); - EXPECT_TRUE(Verifier.match("void f(i) {}", varDecl(), Lang_C99)); + Verifier.e

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

tahonermann added a comment. > Ping for the other reviewers in case they have thoughts. I took a gander and it all looks good to me. I added one comment regarding a test change. Comment at: clang/unittests/AST/SourceLocationTest.cpp:135-145 TEST(ParmVarDecl, KNRLocation) {

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added a comment. Ping for the other reviewers in case they have thoughts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.llvm.org/D124258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added a comment. Precommit CI failures are down to just clang-format related ones. However, as with the implicit function declaration diagnostic, I expect there to be a long tail of failing tests which aren't caught by me locally or by the precommit CI bots. My plan is to track th

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168-169 + ``-Wno-error=implicit-int``, or disabled entirely with ``-Wno-implicit-int``. + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wi

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168-169 + ``-Wno-error=implicit-int``, or disabled entirely with ``-Wno-implicit-int``. + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifyin

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:168-169 + ``-Wno-error=implicit-int``, or disabled entirely with ``-Wno-implicit-int``. + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wi

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm happy enough. I see both sides of the C89 debate enough to 'disagree and commit' on that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.l

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman marked 7 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + --

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wimplicit-int`` in C89 mode will now issue + warnings instead of being a noop. ---

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + aaron.ballman wrote: > erichkeane wrote: > > cor3n

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning options + will have no effect. Specifying ``-Wimplicit-int`` in C89 mode will

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + cor3ntin wrote: > erichkeane wrote: > > This nam

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + erichkeane wrote: > This name seems inverse of wha

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added a comment. Some quick comments... I didn't even bother opening the tests besides checking on functionality, so hopefully those are ok too :D Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning op