[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG21c29a8ae053: [OpenCL] Add cl_khr_subgroup_rotate builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.l

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh added a comment. In D124256#3474043 , @Anastasia wrote: > LGTM! I imagine tablegen side is being tested automatically? The TableGen definitions are tested by `clang/test/Headers/opencl-builtins.cl` > Btw do we need to set the feature macro for SP

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh updated this revision to Diff 428652. svenvh added a comment. Added macro and macro test. Added reference to Extension spec section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.llvm.org/D124256 Files: clang/lib/Headers/opencl-c-base.h clang/lib

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I imagine tablegen side is being tested automatically? Btw do we need to set the feature macro for SPIR/SPIR-V target and then test it too? Repository: rG LLVM Github Monorepo

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins for the new OpenCL ex