[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Jake-Egan added a comment. Thanks @sammccall, the test is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250 ___ cfe-commits mailing list cfe-commits@

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall added a comment. 1c65c734c93f8c4d39947e596d7fe89289ce283d will clear the PCH file. If this doesn't fix the problem I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

Re: [PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Hi Jake, I suspect something about the test/runner is nonhermetic, I'm going to try to fix it in the test. This commit changes the serialized PCH format. It looks like this test is not properly hermetic, and is trying to load the PCH from a previous run of the test. It clears the module dir, but

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Jake-Egan added a comment. Hi, this broke a test on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/903/steps/6/logs/FAIL__Clang__pch-with-module_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cd5cd19af0e: [Serialization] write expr dependence bits as a single integer (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Nice savings Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291 + unsigned ExprDependenceBits = llvm::BitWidth; // Abbreviation for EXPR_DEC

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall updated this revision to Diff 424443. sammccall added a comment. Don't hardcode 5 dependence bits in abbreviaions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250 Files: clang/lib/Serializatio

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When exprs are written unabbre