This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2efccf5166f4: [clangd][NFC] Reduce memory usage while
building dex (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
kadircet updated this revision to Diff 424489.
kadircet marked 2 inline comments as done.
kadircet added a comment.
Copy-assign to empty containers rather than clear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124240/new/
https://reviews.llvm.or
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89
+ Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()),
+ std::move(
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89
+ Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()),
+ std::move(E.second));
+TrigramDocs.clear();
sammccall wrote:
> the move h
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89
+ Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()),
+ std::move(E.second));
+TrigramDocs.clear();
the move here does nothing,
kadircet updated this revision to Diff 424417.
kadircet added a comment.
Get rid of shrink_to_fit as PostingList representation doesn't really make a
copy of the vector, but rather build a new representation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
kadircet created this revision.
kadircet added reviewers: sammccall, kbobyrev.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-e
