[PATCH] D124149: [NFC] follow up code cleanup after D123837

This revision was automatically updated to reflect the committed changes. Closed by commit rGdebd9bf3f019: [NFC] follow up code cleanup after D123837 (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124149/new/ https://reviews.

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu added a comment. In D124149#3500423 , @iains wrote: > sorry for being slow, concentrating on module initialisers! > > this LGTM (but we can still probably make the visibility code cleaner - > perhaps after we get the main functionality installe

[PATCH] D124149: [NFC] follow up code cleanup after D123837

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. sorry for being slow, concentrating on module initialisers! this LGTM (but we can still probably make the visibility code cleaner - perhaps after we get the main functionality installed). Repo

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu added a comment. @iains ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124149/new/ https://reviews.llvm.org/D124149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu added a comment. @iains gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124149/new/ https://reviews.llvm.org/D124149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1573 // attached to the global module and usable within the module unit. - if ((M->isGlobalModule() && !M->Parent) || - // If M is the private module fragment, it is usable only if it is within

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu created this revision. ChuanqiXu added a reviewer: iains. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I found there are chances to do simplify the codes further after I landed D123837