This revision was automatically updated to reflect the committed changes.
aaronpuchert marked 2 inline comments as done.
Closed by commit rGf8afb8fdedae: Thread safety analysis: Store capability kind
in CapabilityExpr (authored by aaronpuchert).
Changed prior to commit:
https://reviews.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with the extra safety measure added. I'm happy to review again if you'd
like, but don't require it.
Comment at: clang/include/clang/Analysis/Analyses/Thre
aaronpuchert added inline comments.
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h:277
+ /// The kind of capability as specified by @ref CapabilityAttr::getName.
+ StringRef CapKind;
+
aaron.ballman wrote:
> Hr, I think this may actu
aaron.ballman added inline comments.
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h:277
+ /// The kind of capability as specified by @ref CapabilityAttr::getName.
+ StringRef CapKind;
+
Hr, I think this may actually be safe, but it d
aaronpuchert created this revision.
aaronpuchert added a reviewer: aaron.ballman.
Herald added a project: All.
aaronpuchert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This should make us print the right capability kind in many more cas
