[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

aeubanks added a comment. polly and clang-fuzzer both call `populateModulePassManager` just to optimize IR, they should be easily migrated to use the new PM bugpoint is still an issue, I just haven't found time to work on it yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay added a comment. So nobody has managed to fix all the in-tree usage. I think having this for the upcoming release/15.x will be nice... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124063/new/ https://reviews.llvm.org/D124063

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

nikic added a comment. @jberdine See https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm-c/Transforms/PassBuilder.h for C bindings for the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124063/new/ https://reviews.ll

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

jberdine added a comment. Apologies if this isn't directly related to this patch in particular, but is there a more informative message that could be given than "Migrate to new pass manager"? In particular, for non-C language bindings that currently call `LLVMPassManagerBuilderPopulateModulePas

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

aeubanks added a comment. I'd first fix up as many in-tree users as nikic pointed out (I'll work on bugpoint soonish since that requires a bit more work) Comment at: llvm/include/llvm-c/Transforms/PassManagerBuilder.h:72 +#ifdef __GNUC__ +__attribute__((deprecated("Migrate to

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay updated this revision to Diff 424374. MaskRay added a comment. I still do not see the argument about C API, but I just drop that changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124063/new/ https://reviews.llvm.org/D124063 Files: c

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

nikic added a comment. In D124063#3461171 , @MaskRay wrote: > In D124063#3461133 , @nikic wrote: > >> Please do not change names in the FFI API at least. It's okay to drop it >> entirely, but renaming is unnecess

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay marked an inline comment as done. MaskRay added a comment. In D124063#3461133 , @nikic wrote: > Please do not change names in the FFI API at least. It's okay to drop it > entirely, but renaming is unnecessarily hostile for FFI APIs. Why? Repos

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

nikic added a comment. Please do not change names in the FFI API at least. It's okay to drop it entirely, but renaming is unnecessarily hostile for FFI APIs. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:95 +#endif + Builder.populateModulePassManagerLegacy(

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay created this revision. MaskRay added reviewers: aeubanks, nikic. Herald added a reviewer: deadalnix. Herald added subscribers: ormris, StephenFan, kbarton, hiraditya, nemanjai. Herald added a reviewer: bollu. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added