[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

delcypher added a comment. @aaron.ballman Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124054/new/ https://reviews.llvm.org/D124054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d612a930dce: [NFC] Avoid unnecessary duplication of code generating diagnostic. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12405

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124054/new/ https://reviews.llvm.org/D124054

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

delcypher created this revision. delcypher added reviewers: rapidsna, fcloutier, aaron.ballman. Herald added a project: All. delcypher requested review of this revision. Herald added a project: clang. The previous code unneccessarily duplicated the creation of a diagnostic where the only differenc