Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

2015-08-27 Thread Daniel Jasper via cfe-commits
I see.. I think we'll want to keep the current behavior there.. On Aug 27, 2015 3:38 PM, "Beren Minor" wrote: > Alright, my bad. It does indeed. > > I was trying to add a "Reformat all on save" feature in the plugin, and > after struggling with VSSDK I thought this would be an easy first step. >

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

2015-08-27 Thread Beren Minor via cfe-commits
Alright, my bad. It does indeed. I was trying to add a "Reformat all on save" feature in the plugin, and after struggling with VSSDK I thought this would be an easy first step. -- Beren Minor On Thu, Aug 27, 2015 at 3:36 PM, Aaron Ballman wrote: > On Thu, Aug 27, 2015 at 9:34 AM, Daniel Jasper

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

2015-08-27 Thread Aaron Ballman via cfe-commits
On Thu, Aug 27, 2015 at 9:34 AM, Daniel Jasper via cfe-commits wrote: > If nothing is selected, clang-format should format the current line.. At > least that's the intended behavior. Doesn't it do that? It currently reformats the current line (possibly extended if the expression spans multiple li

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

2015-08-27 Thread Daniel Jasper via cfe-commits
If nothing is selected, clang-format should format the current line.. At least that's the intended behavior. Doesn't it do that? On Aug 27, 2015 3:21 PM, "Beren Minor" wrote: > berenm created this revision. > berenm added a reviewer: djasper. > berenm added a subscriber: cfe-commits. > > By defau

[PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

2015-08-27 Thread Beren Minor via cfe-commits
berenm created this revision. berenm added a reviewer: djasper. berenm added a subscriber: cfe-commits. By default, clang-format VS plugin only reformats the selected code. To reformat the whole document, the user has to select everything before calling the reformat shortcut. http://reviews.ll