[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG74384c7fcec7: Disable update_cc_test_checks.py tests in stand-alone builds (authored by tstellar). Repository: rG LLVM

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

h-vetinari added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. @h-vetinari Do these updates look OK to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:19 +# for any of the clang source code. +config.unsupported = True else: h-vetinari wrote: > I couldn't tell from the diff where this is used (though admitte

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 449681. tstellar marked an inline comment as done. tstellar added a comment. Fix option spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

h-vetinari added a comment. Just comments, looks OK otherwise. Comment at: clang/test/CMakeLists.txt:6 CLANG_BUILD_EXAMPLES + CLANG_BUILT_STANDALONE CLANG_DEFAULT_PIE_ON_LINUX OT for this PR, but it would be nice to eventually rename this to `CLANG_BUIL

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 424040. tstellar added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test/CMakeLists.txt clang/test/lit.site.c

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

rovka added a comment. I just have a couple of nits, I'll leave it to the clang devs to properly review this. Comment at: clang/test/CMakeLists.txt:17 LLVM_WITH_Z3 + CLANG_BUILT_STANDALONE ) Nit: These seem to be sorted alphabetically. ===

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The script is located in the llvm/ sub-directory, so it is not available for when doing a stand-alone build. Repository: rG