[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. Thank you to everyone for the great feedback! In D123957#3459975 , @xbolva00 wrote: > Can you please add link to RFC to commit message? Good call, I added that when landing. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123957: Update the developer policy to mention release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG009048ab314f: Update the developer policy to mention release notes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123957: Update the developer policy to mention release notes

lattner accepted this revision. lattner added a comment. Nice, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123957: Update the developer policy to mention release notes

tschuett added a comment. LGTM and thanks. Feel free to ignore my comment. Maybe sort entries by importance. I have problems reading longish texts and documents. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___

[PATCH] D123957: Update the developer policy to mention release notes

xbolva00 added a comment. Can you please add link to RFC to commit message? Otherwise looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D123957: Update the developer policy to mention release notes

nikic accepted this revision. nikic added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +* Addi

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423683. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. - Made it more clear that adding a release note is discretionary rather than mandatory - Clarified that bug fix release notes shoul

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. In D123957#3459557 , @lattner wrote: > This is awesome, I agree completely we should curate release notes better. > That said, I think this should make it more clear that there is a "difference > in kind" between user-fac

[PATCH] D123957: Update the developer policy to mention release notes

lattner added a comment. Also, when this lands, we should post on the forum about it. Every change to the developer policy warrants broader visibility than just a phab discussion IMO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957

[PATCH] D123957: Update the developer policy to mention release notes

lattner added a comment. This is awesome, I agree completely we should curate release notes better. That said, I think this should make it more clear that there is a "difference in kind" between user-facing tools like clang/lldb etc and other libraries in LLVM. We don't want release note burd

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +* Adding or removing an optimization. nikic wrote: > I disag

[PATCH] D123957: Update the developer policy to mention release notes

nikic requested changes to this revision. nikic added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database

[PATCH] D123957: Update the developer policy to mention release notes

hans added a comment. Looks great to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a subscriber: xbolva00. aaron.ballman added a comment. In D123957#3458354 , @hans wrote: > If it's possible, maybe this could be worded in a way that strongly suggests > the release notes should ideally be updated in the same patch as

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423594. aaron.ballman added a comment. Something went funny during a rebase, so this is the full update, not just changes since last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 Files: ll

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423593. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. Fixed some grammar issues, added a bullet for fixing bugs, modified the bullet about diagnostics to include regrouping under a new

[PATCH] D123957: Update the developer policy to mention release notes

jhenderson accepted this revision. jhenderson added a comment. LGTM, with suggested nits. Comment at: llvm/docs/DeveloperPolicy.rst:188 +notes, typically found in ``docs/ReleaseNotes.rst`` for the project. Changes to +a project that are user-facing or users may wish to know abo

[PATCH] D123957: Update the developer policy to mention release notes

hans added a comment. If it's possible, maybe this could be worded in a way that strongly suggests the release notes should ideally be updated in the same patch as the code change? I think we're generally good at doing this for tests. It would be great if we could treat release notes the same.

[PATCH] D123957: Update the developer policy to mention release notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 __

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman created this revision. aaron.ballman added a reviewer: lattner. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. As a project, Clang has gotten negative public feedback about our lack of communicating changes to users. There