[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8f822ad5195: [clang][dataflow] Ensure well-formed flow conditions. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423945. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:884 +// +// Note: currently, abstract function calls are uninterpreted, so the test +// exercises this case. If and when we change t

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel added a comment. Thanks for the review! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:110 +// FIXME: The flow condition must be an r-value, so `SkipPast::None` should +// suffice. xazax.hun wrote: > I am still not

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423693. ymandel marked 2 inline comments as done. ymandel added a comment. added fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/Flo

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423690. ymandel added a comment. add comments to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAn

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:110 +// FIXME: The flow condition must be an r-value, so `SkipPast::None` should +

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:123-136 + } else if (auto *CondVal = cast_or_null( + Env.getValue(Cond, SkipPast::None))) { +Env.

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423682. ymandel added a comment. address comments; move tests to proper locations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/FlowSens

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:112-113 cast_or_null(Env.getValue(Cond, SkipPast::Reference)); -if (Val == nullptr) - return; +// Value merging depends on flow conditions from differe

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Ensure that the expressions associated with terminators are asso