This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6f20744b7ff8: Add support for ignored bitfield conditional
codegen. (authored by erichkeane).
Herald added a project: clang.
Repository:
rG LLVM G
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123680/new/
https://reviews.llvm.org/D123680
___
cfe-commits mailing list
cfe-commi
erichkeane updated this revision to Diff 422539.
erichkeane added a comment.
Added support for chained-conditional operators as requested. All of the
variants I could come up with that I was afraid would be breaking ended up
having an rvalue conversion (which makes it 'work').
CHANGES SINCE L
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:200
+ E->IgnoreParenNoopCasts(getContext( {
+if (CondOp->getObjectKind() == OK_BitField)
+ return EmitIgnoredConditionalOperator(CondOp);
efriedma wrote:
> Is there s
efriedma added a comment.
This is basically what I expected; the general approach seems fine.
Comment at: clang/lib/CodeGen/CGExpr.cpp:200
+ E->IgnoreParenNoopCasts(getContext( {
+if (CondOp->getObjectKind() == OK_BitField)
+ return EmitIgnoredConditionalO
erichkeane created this revision.
erichkeane added reviewers: eli.friedman, aaron.ballman, tahonermann.
Herald added a project: All.
erichkeane requested review of this revision.
Currently we emit an error in just about every case of conditionals
with a 'non simple' branch if treated as an LValue.
