[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall marked an inline comment as done. sammccall added a subscriber: hliao. sammccall added a comment. In D123668#3466376 , @maryammo wrote: > It seems it breaks the following builds: > https://lab.llvm.org/buildbot/#/builders/121/builds/18618 > htt

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

maryammo added a comment. It seems it breaks the following builds: https://lab.llvm.org/buildbot/#/builders/121/builds/18618 https://lab.llvm.org/buildbot/#/builders/57/builds/17125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123668/new/ https:/

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

thakis added a comment. (In general, be wary when you write a CL desc that goes "people currently do X in the following N ways, so let's add a N+1th way". This feels short-term good for you since the N+1th way is written exactly like you'd write it – you wrote it, after all! But for everyone el

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

thakis added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:18 + clangBasic + clangFrontend + ) Making clang/lib/Testing depend on clangFrontend (and hence on basically everything) seems pretty heavy. Maybe this should be in a new library? Re

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall added a comment. In D123668#3465771 , @vitalybuka wrote: > Breaks multiple builders > https://lab.llvm.org/buildbot/#/builders/169/builds/7648 > https://lab.llvm.org/buildbot/#/builders/70/builds/20812 > https://lab.llvm.org/buildbot/#/builders

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

vitalybuka added a comment. Breaks multiple builders https://lab.llvm.org/buildbot/#/builders/169/builds/7648 https://lab.llvm.org/buildbot/#/builders/70/builds/20812 https://lab.llvm.org/buildbot/#/builders/77/builds/16736 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rGa7691dee2d3c: [Testing] TestAST, a helper for writing straight-line AST tests (authored by sammccall). C

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks, this looks good; just few nits regarding the comments. Comment at: clang/include/clang/Testing/TestAST.h:9 +// +// In normal operation of clang, the FrontendActio

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall added a comment. ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123668/new/ https://reviews.llvm.org/D123668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Tests that need