Re: [PATCH] D12366: Avoid unnecessarily storing vtable pointers in more destructor cases

2015-08-27 Thread scott douglass via cfe-commits
scott-0 added a comment. Thanks for the review and advice; I'll give `undef` a try. It's a much simpler approach. http://reviews.llvm.org/D12366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D12366: Avoid unnecessarily storing vtable pointers in more destructor cases

2015-08-26 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. Comment at: lib/CodeGen/CGClass.cpp:1369-1382 @@ +1368,16 @@ + +void VisitCallExpr(const Expr *E) { + Sensitive = true; +} +void VisitCXXTypeidExpr(const Expr *E) { + Sensitive = true; +} +void VisitExpr(const Expr *

[PATCH] D12366: Avoid unnecessarily storing vtable pointers in more destructor cases

2015-08-26 Thread scott douglass via cfe-commits
scott-0 created this revision. scott-0 added a subscriber: cfe-commits. This makes an existing optimization apply in more cases. http://reviews.llvm.org/D12366 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/destructors.cpp Index: test/CodeGenCXX/destructors.cpp =