[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

sammccall added a comment. Thanks Nico! @MaskRay my guess is this is related to implicit -fdelayed-template-parsing on windows, which causes non-instantiated templates not really to be parsed. If that's the case, best just to add -fno-delayed-template-parsing to the test and accept that these c

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Err, actually in dd47ab750b584a320bf61d58a3965a03f3871c1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655 ___ cfe-commits mailing list c

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Reverted in a29d9ba1f584745c1a169da5d08f10b27623cfb0 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/56334/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.ll

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73da7eed8fac: [clang-tidy] Add portability-std-allocator-const check (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D123