This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd791de0e25e1: Restrict lvalue-to-rvalue conversions in
CGExprConstant. (authored by efriedma).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1096
+case CK_LValueToRValue: {
+ // We don't really support doing lvalue-to-rvalue conversions here; any
+ // interesting conversions should be done in Evaluate(). But as a
--
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thanks for catching this (sorry, pretty sure this was my bug)!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123648/new/
https://reviews.llvm.org/D123648
__
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123648/new/
https://reviews.llvm.org/D123648
___
Miss_Grape added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1096
+case CK_LValueToRValue: {
+ // We don't really support doing lvalue-to-rvalue conversions here; any
+ // interesting conversions should be done in Evaluate(). But as a
efriedma created this revision.
efriedma added reviewers: aaron.ballman, rjmccall, rsmith.
Herald added a project: All.
efriedma requested review of this revision.
Herald added a project: clang.
We were generating wrong code for cxx20-consteval-crash.cpp: instead of loading
a value of a variable,
