benshi001 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430
+ // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows.
+ return (Twine("libclang_rt.") + Component + Arch + ".a").str();
+}
benshi001 wrote:
> MaskRay wr
benshi001 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430
+ // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows.
+ return (Twine("libclang_rt.") + Component + Arch + ".a").str();
+}
MaskRay wrote:
> benshi001 wr
benshi001 updated this revision to Diff 427821.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123612/new/
https://reviews.llvm.org/D123612
Files:
clang/lib/Driver/ToolChains/AVR.cpp
clang/lib/Driver/ToolChains/AVR.h
clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430
+ // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows.
+ return (Twine("libclang_rt.") + Component + Arch + ".a").str();
+}
benshi001 wrote:
> This method
benshi001 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430
+ // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows.
+ return (Twine("libclang_rt.") + Component + Arch + ".a").str();
+}
This method decides the file
benshi001 updated this revision to Diff 423366.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123612/new/
https://reviews.llvm.org/D123612
Files:
clang/lib/Driver/ToolChains/AVR.cpp
clang/lib/Driver/ToolChains/AVR.h
clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5
benshi001 updated this revision to Diff 422388.
Herald added a subscriber: ormris.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123612/new/
https://reviews.llvm.org/D123612
Files:
clang/lib/Driver/ToolChains/AVR.cpp
clang/lib/Driver/ToolChains/AVR.h
clang/test/Driver/Inputs/basic_
benshi001 added a comment.
As changes in https://reviews.llvm.org/D123200,
it whould be better to support "--rtlib=compiler-rt" on AVR first.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123612/new/
https://reviews.llvm.org/D123612
_
benshi001 created this revision.
benshi001 added reviewers: aykevl, MaskRay, dylanmckay.
Herald added subscribers: StephenFan, Jim, dberris.
Herald added a project: All.
benshi001 requested review of this revision.
Herald added subscribers: cfe-commits, jacquesguan.
Herald added a project: clang.