[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-05-07 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} benshi001 wrote: > MaskRay wr

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-05-07 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} MaskRay wrote: > benshi001 wr

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-05-07 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 427821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-05-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} benshi001 wrote: > This method

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-05-06 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} This method decides the file

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-04-18 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 423366. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-04-12 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 422388. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-04-12 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. As changes in https://reviews.llvm.org/D123200, it whould be better to support "--rtlib=compiler-rt" on AVR first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 _

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

2022-04-12 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay, dylanmckay. Herald added subscribers: StephenFan, Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.