[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett abandoned this revision. DavidSpickett added a comment. People are leaning toward fixes on the buildkite side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 ___

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-14 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. Ok, so maybe my concerns about testing overhead are not that legitimate. That's just something I've heard mentioned in the past. However, I still think this should be fixed in buildkite. It's seems much more sustainable to just bump the timeout in buildkite rather

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-13 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. (splitting up huge monolithic tests likely also speeds up overall testing time on multi-core systems) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 __

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-13 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D123601#3445601 , @tstellar wrote: > Can't we add a timeout exception for this test in buildkite? Splitting the > file in two actually increases the runtime, due to the overhead of setting up > each test. I don't know, this i

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-12 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-12 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/54821. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 ___ cfe-commits mailing li

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

2022-04-12 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should reduce the per test execution time and prevent timeouts in