Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-23 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Jan-22, at 18:01, Eric Fiselier wrote: > > > > On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith > wrote: > > > On 2016-Jan-21, at 22:22, Eric Fiselier wrote: > > > > > > > > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith > > wrote: > > > > > On 2016-Jan-21,

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-22 Thread Eric Fiselier via cfe-commits
On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2016-Jan-21, at 22:22, Eric Fiselier wrote: > > > > > > > > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith < > dexonsm...@apple.com> wrote: > > > > > On 2016-Jan-21, at 17:59, Eric Fiselie

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-22 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Jan-21, at 22:22, Eric Fiselier wrote: > > > > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith > wrote: > > > On 2016-Jan-21, at 17:59, Eric Fiselier wrote: > > > > EricWF added a comment. > > > > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote: > > > >> Thi

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-21 Thread Eric Fiselier via cfe-commits
On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2016-Jan-21, at 17:59, Eric Fiselier wrote: > > > > EricWF added a comment. > > > > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote: > > > >> This patch looks correct to me. Is there any

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-21 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Jan-21, at 17:59, Eric Fiselier wrote: > > EricWF added a comment. > > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote: > >> This patch looks correct to me. Is there any reason it wasn't committed? > > > I was concerned about using a function-local static in the librar

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-21 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote: > This patch looks correct to me. Is there any reason it wasn't committed? I was concerned about using a function-local static in the library headers, I don't think libc++ does that anywhere else and I wanted

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-20 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. This patch looks correct to me. Is there any reason it wasn't committed? http://reviews.llvm.org/D12354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2016-01-20 Thread Duncan P. N. Exon Smith via cfe-commits
This patch looks correct to me. Is there any reason it wasn't committed? > On 2015-Aug-25, at 22:22, Eric Fiselier via cfe-commits > wrote: > > EricWF updated this revision to Diff 33180. > EricWF added a comment. > > Cleanup the diff and remove extra changes. > > > https://urldefense.proof

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2015-08-25 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 33180. EricWF added a comment. Cleanup the diff and remove extra changes. http://reviews.llvm.org/D12354 Files: include/__debug include/algorithm test/libcxx/algorithms/debug_less.pass.cpp test/support/debug_mode.h Index: test/support/debug_mode.h =

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2015-08-25 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 33179. EricWF added a comment. Remove all functions in the dylib and make them inline. http://reviews.llvm.org/D12354 Files: include/__debug include/algorithm include/regex src/debug.cpp test/libcxx/algorithms/debug_less.pass.cpp test/support/deb

[PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

2015-08-25 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch adds a global assertion handler that is called when _LIBCPP_ASSERT fails. This allows us to test debug mode features without _LIBCPP_ASSERT always calling `abort()`. This patch