[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7443a504bf6c: [clang][extract-api] Add support for true anonymous enums (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123533/new/ https://reviews.llvm.org/D123533 ___ c

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang updated this revision to Diff 422296. dang marked an inline comment as done. dang added a comment. Add a second anonymous enum to the test case to make sure that distinct symbols are generated for both of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

zixuw added inline comments. Comment at: clang/test/ExtractAPI/enum.c:693 +], +"title": "(anonymous)" + }, dang wrote: > zixuw wrote: > > So the `Name` of the record is literally `(anonymous)`? I think this might > > create problems (well I

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang marked 3 inline comments as done. dang added inline comments. Comment at: clang/test/ExtractAPI/enum.c:693 +], +"title": "(anonymous)" + }, zixuw wrote: > So the `Name` of the record is literally `(anonymous)`? I think this might > crea

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang updated this revision to Diff 422160. dang added a comment. Address code review feedback: - Normalize test file URIs - Key RecordMaps by USR instead of by Name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123533/new/ https://reviews.llvm.org

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

zixuw added inline comments. Comment at: clang/test/ExtractAPI/enum.c:684 +}, +"uri": "file:///Users/dgrumberg/VersionControlledDocuments/oss/llvm-project/build/tools/clang/test/ExtractAPI/Output/enum.c.tmp/input.h" + }, nit: normalize ===

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Anonymous enums without a typedef should have a "(anonymous)" identifier.