This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe5000624933e: [clangd] Fix incorrect operator< impl for
HighlightingToken (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
nridge updated this revision to Diff 422410.
nridge added a comment.
Add semantic highlighting testcase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123478/new/
https://reviews.llvm.org/D123478
Files:
clang-tools-extra/clangd/SemanticHighlighti
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Oopsy :/ Thanks for the fix!
Regarding the test, if you came looking for this piece due to a particular
issue, it might be nice to have that included in the test suite (assuming it
can be
nridge added a comment.
Not sure how to write a test for this, short of writing unit tests for the
operator< itself. The consequence of this bug is that the sort/unique pass on
the highlighting tokens is buggy, but as of
https://github.com/clangd/clangd/issues/1057 `resolveConflict()` fixes up
nridge created this revision.
nridge added reviewers: sammccall, kadircet.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
