[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5114db933dbf: [analyzer] Clean checker options from bool to DefaultBool (NFC) (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-23 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Good stuff. Update the summary and title, and I think good to go. In addition to this, we should do something similar with the rest of the checker options and initialize them at the declar

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-23 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Hi @steakhal, I believe I've addressed the comments. Please have a look and let me know if this is what you were after. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123464/new/ https://reviews.llvm.org/D123464 _

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-23 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 424720. vabridgers added a comment. refactor patch to remove DefaultBool, replace with bool as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123464/new/ https://reviews.llvm.org/D123464 Files: c

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-19 Thread Balázs Benics via Phabricator via cfe-commits
steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. > A recent review emphasized the preference to use DefaultBool instead of bool > for checker options. What I wanted to highlight is that we should aim for consistency. We should

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-10 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review of this r