[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

dblaikie added a comment. In D123436#3475858 , @junaire wrote: > In D123436#3475002 , @dblaikie > wrote: > >> In D123436#3462567 , @dblaikie >> wrote: >> >>> Perhaps Glo

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

junaire added a comment. In D123436#3475002 , @dblaikie wrote: > In D123436#3462567 , @dblaikie > wrote: > >> Perhaps GlobalModuleIndex should create the cursor itself - it's being >> handed the buffer anyway? >

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

dblaikie added a comment. In D123436#3462567 , @dblaikie wrote: > Perhaps GlobalModuleIndex should create the cursor itself - it's being handed > the buffer anyway? Ping on this ^ - would this be a better direction that addresses the concerns? Reposit

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG218dcdad8a0c: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D123436 _