This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rG4ea1d435099f: [CUDA][HIP] Externalize kernels in anonymous
name space (authored by yaxunl).
Herald added a p
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13
+
+// CHECK: define weak_odr {{.*}}void
@[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]](
+// CHECK: @[[STR:.*]] = {{.*}} c"[[KERN]]\00"
--
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM overall.
Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13
+
+// CHECK: define weak_odr {{.*}}void
@[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]](
+// CHECK: @[[STR:
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13
+
+// CHECK: define weak_odr {{.*}}void
@[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]](
+// CHECK: @[[STR:.*]] = {{.*}} c"[[KERN]]\00"
--
tra added inline comments.
Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13
+
+// CHECK: define weak_odr {{.*}}void
@[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]](
+// CHECK: @[[STR:.*]] = {{.*}} c"[[KERN]]\00"
Will the externalized names be uniquified
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added a project: All.
yaxunl requested review of this revision.
kernels in anonymous name space needs to have unique name
to avoid duplicate symbols.
Fixes: https://github.com/llvm/llvm-project/issues/54560
https://reviews.llvm.
