This revision was automatically updated to reflect the committed changes.
Closed by commit rG88a7508b1fd8: [clang-tidy] Deal with keyword tokens in
preprocessor conditions (authored by LegalizeAdulthood).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
LegalizeAdulthood updated this revision to Diff 421628.
LegalizeAdulthood added a comment.
Update from review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123349/new/
https://reviews.llvm.org/D123349
Files:
clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp
clang
LegalizeAdulthood added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281
+inline StringRef getTokenName(const Token &Tok) {
+ return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifier()
aaron.ballman wrote:
> Legaliz
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281
+inline StringRef getTokenName(const Token &Tok) {
+ return Tok.is(tok::raw
LegalizeAdulthood updated this revision to Diff 421603.
LegalizeAdulthood marked an inline comment as done.
LegalizeAdulthood added a comment.
Update from review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123349/new/
https://reviews.llvm.org/D123349
Files:
clang-tools-ext
LegalizeAdulthood marked 4 inline comments as done.
LegalizeAdulthood added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281
+inline StringRef getTokenName(const Token &Tok) {
+ return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifi
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281
+inline StringRef getTokenName(const Token &Tok) {
+ return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifier()
inline is pretty redundant here. Did yo
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: aaron.ballman.
LegalizeAdulthood added a project: clang-tools-extra.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
LegalizeAdulthood requested review of this revision.
When a "keyword" t
