serge-sans-paille added a comment.
@nickdesaulniers changes taken into account and pushed, thanks for the review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123308/new/
https://reviews.llvm.org/D123308
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rG301e0d91354b: [Clang][Fortify] drop inline decls when
redeclared (authored by serge-sans-paille).
Changed prior to commit:
https://reviews.llvm.org/D123308?vs=421187&id=421438#toc
Repository:
rG LLVM
nickdesaulniers added a comment.
Also, for the initial lines of commit messages, please try to make them less
ambiguous about which parts of the project they touch. For example
`[Clang][Fortify] drop inline decls when redeclared` is more descriptive should
this get bucketed with other commits
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
Thanks for the quick fix!
Comment at: clang/lib/CodeGen/CGExpr.cpp:4968-4969
// name to make it clear it's not the actual builtin.
-if (FD->isInlin
serge-sans-paille created this revision.
serge-sans-paille added reviewers: nickdesaulniers, aaron.ballman, tstellar.
Herald added a project: All.
serge-sans-paille requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When an inline builtin decl
