Re: [PATCH] D12321: Avoid LoopConvertCheck replacements in template instantiations.

2015-08-25 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thanks! Still looks good. http://reviews.llvm.org/D12321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12321: Avoid LoopConvertCheck replacements in template instantiations.

2015-08-25 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 33081. angelgarcia added a comment. Add test. http://reviews.llvm.org/D12321 Files: clang-tidy/modernize/LoopConvertCheck.cpp test/clang-tidy/modernize-loop-convert-extra.cpp Index: test/clang-tidy/modernize-loop-convert-extra.cpp =

Re: [PATCH] D12321: Avoid LoopConvertCheck replacements in template instantiations.

2015-08-25 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a comment. Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:636 @@ +635,3 @@ + SE = container.end(); SI != SE; ++SI) { + } +} --

[PATCH] D12321: Avoid LoopConvertCheck replacements in template instantiations.

2015-08-25 Thread Angel Garcia via cfe-commits
angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. Prevent LoopConvertCheck from doing replacements in template instantiations, and add a test. http://reviews.llvm.org/D12321 Files: clang-tidy/modernize/LoopConvertCheck