This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaebe5fc6e7d8: [clang][extract-api] Process only APIs
declared in inputs (authored by dang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
dang updated this revision to Diff 421143.
dang added a comment.
Rebase on top of latest changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123148/new/
https://reviews.llvm.org/D123148
Files:
clang/include/clang/ExtractAPI/FrontendActions.h
cishida accepted this revision.
cishida added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123148/new/
https://reviews.llvm.org/D123148
_
dang marked 2 inline comments as done.
dang added inline comments.
Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:72
+// primarily to resolve headers found via headermaps, as they remap
+// locations.
+const auto *FileInfo = PP.getHeaderSearchInfo().getExisti
dang updated this revision to Diff 420875.
dang marked 2 inline comments as done.
dang added a comment.
Address code review feedback:
- Remove unnecessary code
- Add a test to validate that everything works in the presence of header maps
- Simplify existing test
- Fix small nits
Repository:
r
zixuw added inline comments.
Comment at: clang/test/ExtractAPI/known_files_only.c:20
+// Let's make sure we aren't pulling in symbols from complex.h
+#include
+double complex build_complex(double real, double imaginary);
I would just include another header split
cishida added inline comments.
Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:66
+// Check if we have looked up this particular file entry previously instead
+// of querying the preprocessor for externsal sources.
+if (UnknownFileEntries.count(File))
dang created this revision.
dang added reviewers: zixuw, ributzka, QuietMisdreavus, cishida.
Herald added a project: All.
dang requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We should only process APIs declared in the command line inputs t
