[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

This revision was automatically updated to reflect the committed changes. Closed by commit rGda1fc3ae955d: [Driver][NFC] Simplify handling of flags in Options.td (authored by ekieri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123070/new/ https:/

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

hans added a comment. In D123070#3430207 , @ekieri wrote: > @hans , thanks, that is a valid concern. I was asked to add closing comments > on an earlier patch though, and I find them particularly useful (when > accurate...) in this file, which does not

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

awarzynski added a comment. In D123070#3429519 , @hans wrote: > I worry that the closing comments on '}'s might rot since there's no tooling > to maintain them though. I share your concern. However, from my experience these `let` statements rarely chan

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri added a comment. Thank you all for the support! @jansvoboda11 , yes, I did that, and will do it again before pushing. @hans , thanks, that is a valid concern. I was asked to add closing comments on an earlier patch though, and I find them particularly useful (when accurate...) in this f

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

hans accepted this revision. hans added a comment. Looks reasonable to me. I worry that the closing comments on '}'s might rot since there's no tooling to maintain them though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123070/new/ https://rev

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

jansvoboda11 accepted this revision. jansvoboda11 added a comment. Thank you for working on this! I you haven't already, I suggest you test this change by dumping all TableGen records in the backend and comparing the before and after. When working on `Options.td`, I found it quite easy to intro

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

awarzynski accepted this revision. awarzynski added a subscriber: jansvoboda11. awarzynski added a comment. This revision is now accepted and ready to land. Thanks for doing this, Emil! This is a much appreciated clean-up. On quite a few occasions I got confused with the nested `let` statements.

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri added a comment. This patch is the result of discussions in https://reviews.llvm.org/D122542 There are probably a developer or two on the clang side that ought to have a say on this. I do not know the community that well, could you please help me with adding the appropriate people? Rep

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri created this revision. ekieri added reviewers: awarzynski, thakis. Herald added a reviewer: sscalpone. Herald added a project: All. ekieri requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. W